First off, it’s important to note that the research only shows an association between optimism and a longer life. This is not the same as saying that being more optimistic directly causes a longer life – correlation does not equal causation.
Secondly, the research only focuses on a narrow set of people who are disproportionately white, better off and from two specific occupations (nursing and ex-army) compared to the general population of the USA. This raises an important question: how likely is it that these findings will apply to the much more diverse and less well-off broader population in the USA, let alone in the UK?
Thirdly, with studies of this kind you have to ‘control’ for other factors in order to isolate the impact of one variable (in this case optimism) on the final outcome (longer life). There are a huge range of things beyond optimism that might enable someone to live longer, including socio-economic factors such as gender, race and income, health conditions such as type 2 diabetes or having had a heart attack, and health behaviours such as smoking, diet and physical activity.
The headline findings reported by news outlets do include controls for some socio-economic factors and health conditions, but not for health behaviours. When those are considered the associated 11%-15% increase in lifespan drops to about 9%. Comparing this to the impact that never having been diagnosed with type 2 diabetes and never having had a heart attack has on how much longer we can expect someone to live (17% and 18% respectively) really puts things into perspective.
Finally, the findings reported by many news outlets ignore that when you include health behaviours in the analysis, the increased chance of living to 85 due to being optimistic becomes statistically insignificant (meaning that the difference in numbers could be entirely due to random chance).